Enhanced Random-Death Reporting #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added color-coded messaging to ensure random death events are highly noticeable to users. Imported necessary utilities and refined new day processing to utilize the enhanced reporting mechanism.
Added color-coded messaging to ensure random death events are highly noticeable to users. Imported necessary utilities and refined new day processing to utilize the enhanced reporting mechanism.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4879 +/- ##
============================================
- Coverage 10.31% 10.30% -0.01%
+ Complexity 5872 5865 -7
============================================
Files 944 944
Lines 131403 131407 +4
Branches 19064 19064
============================================
- Hits 13548 13542 -6
- Misses 116539 116549 +10
Partials 1316 1316 ☔ View full report in Codecov by Sentry. |
Extended the message to clarify when no active contract is selected or the contract has not yet started. This provides better feedback to users regarding the state of their campaign.
HammerGS
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added color-coded messaging to ensure random death events are highly noticeable to users. Imported necessary utilities and refined new day processing to utilize the enhanced reporting mechanism.
Note that the double-reporting here is deliberate and only applies to random death events, not normal death or change of status. I made the decision to double-report to ensure the user doesn't miss these rather important events and a dialog was considered overkill (and potentially spammy).
Closes #4870